fix(kas-container): preserve quoting in --runtime-args values - #188
Open
linzhp wants to merge 1 commit into
Open
fix(kas-container): preserve quoting in --runtime-args values#188linzhp wants to merge 1 commit into
linzhp wants to merge 1 commit into
Conversation
The accumulated --runtime-args string is expanded unquoted, so it is word-split without honoring any quoting inside it. This makes it impossible to pass runtime arguments whose values contain spaces, e.g. kas-container --runtime-args "--device-cgroup-rule 'b 7:* rmw'" ... which the engine receives as the four arguments "--device-cgroup-rule", "'b", "7:*" and "rmw'". Expand KAS_EXTRA_RUNTIME_ARGS through eval instead, so shell quoting inside the user-supplied string survives and such values reach the container engine intact. Space-separated flags without quoting behave as before, and repeated --runtime-args usage still accumulates. Only the user-supplied string is eval'd; the internal argument lists keep the plain word-splitting expansion. Signed-off-by: Zhongpeng Lin <zplin@uber.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
|
Thanks for this patch! Would you mind sending it to the mailing list as well (see https://github.com/siemens/kas/blob/master/CONTRIBUTING.md)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accumulated --runtime-args string is expanded unquoted, so it is word-split without honoring any quoting inside it. This makes it impossible to pass runtime arguments whose values contain spaces, e.g.
which the engine receives as the four arguments "--device-cgroup-rule", "'b", "7:*" and "rmw'".
Expand
KAS_EXTRA_RUNTIME_ARGSthrough eval instead, so shell quoting inside the user-supplied string survives and such values reach the container engine intact. Space-separated flags without quoting behave as before, and repeated--runtime-argsusage still accumulates. Only the user-supplied string is eval'd; the internal argument lists keep the plain word-splitting expansion.